Repository navigation
[Rust] multimodal generation back-ported on vllm v0.28.0 - #56421
Draft
biswapanda wants to merge 3 commits into
Draft
biswapanda wants to merge 3 commits into
biswapanda wants to merge 3 commits into
Conversation
Signed-off-by: Biswa Panda <biswa.panda@gmail.com>
Signed-off-by: Biswa Panda <biswa.panda@gmail.com>
Signed-off-by: Biswa Panda <biswa.panda@gmail.com>
biswapanda
marked this pull request as draft
September 11, 2026 15:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add the minimal vLLM 0.28 Rust frontend support needed for Dynamo-backed Qwen3.5 image generation during RL training.
This is not a duplicate of #55047: that PR targets current
mainand includes broader multimodal work. This branch is based directly onreleases/v0.28.0and keeps only the v0.28 compatibility path required by the tested Dynamo stack.Changes
TextRequest.mm_features.The change intentionally excludes LoRA handling, audio/video support, chat model-limit refactors, and unrelated code from #55047.
Validation
cargo fmt --all -- --checkcargo check -p vllm-server --testscargo test -p vllm-server grpc::convert::tests::— 22 passedcargo test -p vllm-server preprocessed_image— 7 passedcargo test -p vllm-server control_reports_server_and_model_info— 1 passedcargo test -p vllm-engine-core-client --lib— 97 passed, including both output tuple lengthsbis-rl-3with Prime-RL main plus [Core] [Bugfix] Refactor block manager subsystem for better testability #3492, Dynamo [Installation]: #14398 plus the minimal image-only sidecar layer, and this PR: 5/5 orchestrator steps, 5/5 trainer steps, 2/2 trainable rollouts per step, zero rollout errors/cancellations, six NCCL weight receives, and successful pre/post image probes.AI assistance
AI assistance was used to analyze the existing PRs, implement the compatibility backport, and draft tests. The submitting developer reviewed the changes and validation results.